Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message for failing to create model in model-equation endpoint #173

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Error message for failing to create model in model-equation endpoint #173

wants to merge 3 commits into from
+18 −14

Conversation

jClugstor
Copy link
Collaborator

#172

@joshday I'm not super familiar with Oxygen and the HTTP response stuff but I think this is right. Could you make sure this looks right?

@jClugstor jClugstor requested a review from joshday April 12, 2024 18:06
@joshday
Copy link
Collaborator

joshday commented Apr 12, 2024

A few comments:

  1. The HTTP response looks correct.
  2. We'd want the catch block to rethrow the exception so that it shoes up in the sciml-service logs.
  3. I'm not sure this behavior is preferred to just returning 500. All this does is change errors in amr_get from 500 to 422.

@joshday
Copy link
Collaborator

joshday commented Apr 12, 2024

What could we do in terms of validating the MathML?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshday joshday joshday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jClugstor @joshday