Sharing project causes 503 (#4455)

DARPA-ASKEM · Aug 14, 2024 · da6f3c1 · da6f3c1
1 parent 82b567a
commit da6f3c1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/client/hmi-client/src/components/home/tera-project-menu.vue b/packages/client/hmi-client/src/components/home/tera-project-menu.vue
@@ -73,7 +73,7 @@ const projectMenuItems = computed(() => {
 		items.push(renameMenuItem, shareMenuItem, separatorMenuItem, removeMenuItem);
 	}
 	if (props.project?.userPermission === 'writer') {
-		items.push(renameMenuItem, shareMenuItem);
+		items.push(renameMenuItem);
 	}
 	return items;
 });

diff --git a/.../java/software/uncharted/terarium/hmiserver/controller/dataservice/ProjectController.java b/.../java/software/uncharted/terarium/hmiserver/controller/dataservice/ProjectController.java
@@ -1048,8 +1048,10 @@ public ResponseEntity<JsonNode> makeProjectPublic(
 				projectPermissionsService.removeProjectPermissions(project, who, relationship);
 			}
 			return ResponseEntity.ok().build();
+		} catch (final ResponseStatusException rethrow) {
+			throw rethrow;
 		} catch (final Exception e) {
-			log.error("Failed to set project public permissions", e);
+			log.error("Unexpected error, failed to set project public permissions", e);
 			throw new ResponseStatusException(HttpStatus.SERVICE_UNAVAILABLE, messages.get("rebac.service-unavailable"));
 		}
 	}