Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client-event for workflow updates #4741

Merged
merged 14 commits into from
Sep 11, 2024
Merged

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Sep 10, 2024

Summary

Plumbing to receive SSE workflow update events

Schematically, showing how two sessions with the same workflow work with the server.

image

Related to: #4724

Testing

Open the same workflow across 2 or more tabs

  • Add/remove node in one tab
  • Goto the other tabs, they should be synchronized with the origin of change

Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM does the code commented needed or can they be removed?

@mwdchang mwdchang merged commit c9bfec9 into main Sep 11, 2024
8 checks passed
@mwdchang mwdchang deleted the clientside-notification-changes branch September 11, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants