Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize spinner progress #4745

Merged
merged 10 commits into from
Sep 12, 2024
Merged

Optimize spinner progress #4745

merged 10 commits into from
Sep 12, 2024

Conversation

Tom-Szendrey
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey commented Sep 10, 2024 •
edited
Loading

Description

  • Allow for optimize's intermediate results to be captured in CiemssStatusUpdate by adding optional fields
  • Adding currentProgress to optimize state
  • Adding % message to optimize node and drilldown based off of the optimize iteration step.
  • Adding a static message when forecast runs are running.

DEPENDS ON

DARPA-ASKEM/pyciemss-service#116

Testing:

-Running the above pyciemss-service branch we can run optimize which will now have intermediate results sent to rabbitmq
-We can also confirm the type change has no impact on calibration's intermediate results

Pictures

image image

@Tom-Szendrey Tom-Szendrey mentioned this pull request Sep 10, 2024
Merged
@Tom-Szendrey Tom-Szendrey marked this pull request as ready for review September 10, 2024 17:21
@Tom-Szendrey Tom-Szendrey merged commit 1183fde into main Sep 12, 2024
8 checks passed
@Tom-Szendrey Tom-Szendrey deleted the TS/3689 branch September 12, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnyama shawnyama shawnyama approved these changes

@mwdchang mwdchang mwdchang approved these changes

@kbirk kbirk kbirk approved these changes

@dvince2 dvince2 dvince2 approved these changes

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

@YohannParis YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

Assignees

@mwdchang mwdchang

@kbirk kbirk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tom-Szendrey @mwdchang @kbirk @shawnyama @dvince2