Add model name to comparsion #4993
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asylves1
requested review from
YohannParis,
mwdchang,
jryu01,
Tom-Szendrey,
shawnyama and
blanchco
as code owners
mwdchang
reviewed
Oct 1, 2024
| modelsToCompare.value.map((model) => model.name), | ||
| ', ' | ||
| ) | ||
| ); |
There was a problem hiding this comment.
This does not look correct. If modelsToCompare is [X, Y, Z] for example, the generated labels should be something like:
- X vs Y
- X vs Z
- Y vs Z
I don't see how this function does that, also we can probably just use the native Array.join rather than importing a join function from lodash.
There was a problem hiding this comment.
Ah, I will make that change
There was a problem hiding this comment.
@asylves1 note I do not know if we get the pairing information in any specific order, you need to check and possibly modify the model-comparison procedure in beaker to return the information you need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Design Change:
Resolves #(issue)