5016 bug when extracting a configuration we need to distinguish missing values from 0 #5066
+143
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YohannParis
requested review from
mwdchang,
jryu01,
Tom-Szendrey,
shawnyama,
blanchco and
asylves1
as code owners
…need-to-distinguish-missing-values-from-0
…need-to-distinguish-missing-values-from-0
asylves1
approved these changes
Oct 8, 2024
shawnyama
reviewed
Oct 8, 2024
...client/hmi-client/src/components/workflow/ops/model-config/tera-model-configuration-item.vue
Show resolved
Hide resolved
…need-to-distinguish-missing-values-from-0
YohannParis
deleted the
5016-bug-when-extracting-a-configuration-we-need-to-distinguish-missing-values-from-0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the user interface and code structure of several Vue components in the
hmi-clientpackage. The changes include refactoring the structure of tables and lists, updating styles, and optimizing imports and logic.UI Improvements:
tera-initial-other-value-modal.vue: Refactored theDataTablecomponent to reorder attributes for consistency, added sortable columns, and updated styles for better readability. [1] [2] [3] [4] [5] [6]tera-initial-table.vue: Simplified the list structure by removing unnecessary nesteddivelements and dividers, and improved list item styling. [1] [2] [3] [4] [5] [6] [7]tera-model-config-drilldown.vue: Enhanced button alignment and disabled states, added a new computed property to check if the model configuration has changed, and improved styling of the configuration list. [1] [2] [3] [4] [5] [6] [7] [8]tera-model-configuration-item.vue: Updated the layout of the configuration item card, removed the divider, and improved the styling of the header and description. [1] [2]Code Optimization:
tera-initial-other-value-modal.vue: Removed unused imports and redundant code, such as the column width calculation function and theselectedColumnsref. [1] [2] [3] [4]tera-initial-table.vue: Removed theDividercomponent and its related styles, as well as simplified the list structure. [1] [2] [3] [4]tera-model-config-drilldown.vue: Optimized the logic for checking if the model configuration has changed and improved the readability of the computed properties. [1] [2]These changes collectively enhance the maintainability, readability, and user experience of the
hmi-clientpackage.FROM
TO