Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add titles to generated compare models graphs #5100

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Add titles to generated compare models graphs #5100

merged 5 commits into from
Oct 9, 2024
+29 −2

Conversation

asylves1
Copy link
Contributor

@asylves1 asylves1 commented Oct 8, 2024

Description

Design Change:

  • When a user compares multiple models generating a graph. There were no titles added to the image generated.

Code Changes:

  • added a KernelManager message to to request the title pair(s) of the compared models

image

Resolves #(issue)

@asylves1 asylves1 linked an issue Oct 8, 2024 that may be closed by this pull request
[BUG]: Compare models by notebook should create title for the graphs #4964
Closed
@asylves1 asylves1 marked this pull request as ready for review October 8, 2024 19:18
YohannParis
YohannParis approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tom-Szendrey
Tom-Szendrey approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

@asylves1 asylves1 merged commit 3540582 into main Oct 9, 2024
4 checks passed
@asylves1 asylves1 deleted the 4964-bug-compare-models-title-for-graphs branch October 9, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis approved these changes

@Tom-Szendrey Tom-Szendrey Tom-Szendrey approved these changes

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Compare models by notebook should create title for the graphs
3 participants
@asylves1 @YohannParis @Tom-Szendrey