Clean up app.vue #5102
Open
Clean up app.vue #5102
+39
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YohannParis
requested review from
mwdchang,
jryu01,
Tom-Szendrey,
shawnyama,
blanchco and
asylves1
as code owners
shawnyama
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
hmi-clientpackage, focusing on simplifying the layout structure, improving styling consistency, and refactoring the toast notification system.Simplification and Refactoring:
Simplified Toast Notifications: Removed the group attribute from the
Toastcomponent anduseToastServicemethods to streamline the toast notification system. (packages/client/hmi-client/src/App.vue,packages/client/hmi-client/src/services/toast.ts) [1] [2] [3] [4] [5]Layout Simplification: Removed redundant HTML elements and simplified the layout by merging the header, main, and footer sections directly into the template. (
packages/client/hmi-client/src/App.vue)Styling and Layout Improvements:
Footer Component Update: Converted the
sectionelement to afooterelement and updated the styles for better semantic structure and consistency. (packages/client/hmi-client/src/components/navbar/tera-footer.vue) [1] [2] [3]Navbar Component Update: Adjusted padding and margin values to use CSS variables for consistency and added the
grid-areaproperty for better layout control. (packages/client/hmi-client/src/components/navbar/tera-navbar.vue) [1] [2] [3]Functional Improvements:
watchmethod to ensure the project is only updated when theprojectIdchanges. (packages/client/hmi-client/src/App.vue)