Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cleaning up! #5107

Merged
merged 7 commits into from
Oct 9, 2024
Merged

More cleaning up! #5107

merged 7 commits into from
Oct 9, 2024

Conversation

YohannParis
Copy link
Member

This pull request includes significant changes to the tera-document-asset.vue and tera-project.vue components, primarily focusing on code cleanup, refactoring, and simplification. The most important changes include the removal of unused imports and event subscriptions, simplification of the tera-project.vue component, and minor style adjustments.

Code cleanup and refactoring:

  • tera-document-asset.vue: Removed unused imports, event subscriptions, and methods related to document extraction status updates. Simplified the watch function to avoid unnecessary re-fetching of document assets. [1] [2] [3]

Simplification of tera-project.vue component:

  • tera-project.vue: Simplified the component by removing redundant conditional checks and reorganizing the asset view rendering logic. Updated the assetId type and improved the openAsset function to avoid unnecessary updates. [1] [2] [3]

Style adjustments:

  • tera-project.vue: Removed unused styles related to tab groups and adjusted the section layout to improve readability and maintainability.

Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure familiar enough with document-asset to know why we needed subscribe(ClientEventType.ExtractionPdf, subscribeToExtraction)
But aside from that LGTM

@YohannParis
Copy link
Member Author

Not sure familiar enough with document-asset to know why we needed subscribe(ClientEventType.ExtractionPdf, subscribeToExtraction) But aside from that LGTM

Because we used to show the extractions of a document on this page, but not anymore, and the code to fetch them wasn't removed.

@YohannParis YohannParis merged commit 848be0f into main Oct 9, 2024
4 checks passed
@YohannParis YohannParis deleted the 5080-improve-project-sharing branch October 9, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Project Sharing
4 participants