5059 bug unable to see intervention in output chart for calibrate #5110
Conversation
mloppie
requested review from
YohannParis,
mwdchang,
jryu01,
Tom-Szendrey,
shawnyama,
blanchco and
asylves1
as code owners
…t-chart-for-calibrate
| dx: labelXOffset, | ||
| dy: -10 |
There was a problem hiding this comment.
Why only dx deserves a constant?
| Object.entries(groupedInterventionOutputs.value).forEach((item) => { | ||
| item[1].forEach((intervention) => { | ||
| chart.layer.push(...createInterventionChartMarkers([intervention], false, -80)); |
There was a problem hiding this comment.
Why does the node chart uses -80 and not -180 like the drilldown?
| item[1].forEach((intervention) => { | ||
| charts[variable].layer.push(...createInterventionChartMarkers([intervention], false, -180)); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
It looks like we are applying all the interventions to the chart. We are going to end up plotting plotting interventions for variables like I, S, and R all on the same chart. It will create a issue such that chart for variable I also have intervention for other variables, for example S or R along with all interventions for parameters as well. I'm not sure if that's what we want to do. If we want still draw all interventions for parameters to the chart, we should at least filter out the intervention for non target state variables (e.g. S, R etc) I guess and only plot the interventions for the parameters (e.g. beta, alpha etc).
Fixes missing intervention marker in the calibrate node and calibrate drilldown
Resolves #5059