Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
register.sinto a newinit_vaultfunction, eliminatingduplicated logic between base and quote vault paths
token_program_idandtoken_program_is_2022fieldsto
RegisterMarketFrameso INIT-VAULT receives the owningtoken program via the frame instead of a pre-loaded syscall
register
acctfield toRegisterMarketFramefor persisting theaccount pointer across the INIT-VAULT syscall
base and non-duplicate quote token program paths
RETURN_SUCCESSconstant to entrypoint for checkingINIT-VAULT call results
BOOL_FALSEandBOOL_TRUEconstants to memorye_invalid_quote_vault_pubkeyerror label fromerror.s(INIT-VAULT inlines the error return, branchingon
vault_indexto select the correct error code)section in
markets.md.pubkeyto.addressin REGISTER-MARKET pseudocodefor consistency with assembly field names
CreateAccountHappyPathToken2022QuoteDupandCreateAccountHappyPathToken2022QuoteNonDupintegration testslayout.mdfile tree withinit_vault.s