Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
CreateAccount invoke into a standalone INIT-MARKET-PDA
procedure (
init_market_pda.s), entered and exited viaja(no function call overhead, all registers preserved)sysvar before PDA derivation, consolidating all PDA signer
seed initialization into the new procedure
INIT-MARKET-PDA (r9 = acct is never clobbered, so the Rent
sysvar read works inside the procedure)
acctfield fromRegisterMarketFrameand itsRM_FM_ACCT_OFFconstant (r9 survives the entire procedureand both syscalls, making the save/restore unnecessary)
ensure annotations documenting register contracts
markets.mdand register the algorithm inindex.jsonmismatch tests now follow Rent sysvar tests)
pda_mismatch_accountsto provide valid SystemProgram and Rent sysvar accounts (required now that those
checks precede PDA derivation)
// Verifies: INIT-MARKET-PDAcomments to all testcases that exercise the extracted procedure