Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix negative array access on EXS_Unknown #107

Closed
wants to merge 1 commit into from
Closed

Fix negative array access on EXS_Unknown #107

wants to merge 1 commit into from

Conversation

percontation
Copy link

When a DcmXfer is initialized with EXS_Unknown (which does happen), a negative array access happens on XferNames.

The existing XferNames[i].xfer == xfer check prevents anything too wild from happening, unless a build is super unlucky about what appears before XferNames in global memory. But, better not to rely on that.

@jriesmeier
Copy link
Member

Thank you for the report. We will make sure that the issue will be fixed rather soon.

michaelonken pushed a commit that referenced this pull request Aug 2, 2024
@jriesmeier
Fixed invalid array access on EXS_Unknown.
84c57f8 
Fixed invalid access to XferNames array for transfer syntax enum
EXS_Unknown (-1). This issue was introduced only recently with commit
9872714.

Thanks to GitHub user "percontation" for the report and suggested fix.
This closes GitHub pull request #107.
@jriesmeier
Copy link
Member

The required changes have been committed and merged to the master branch: see commit 84c57f8.

@jriesmeier jriesmeier closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@percontation @jriesmeier