Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ofstub.cc: fix environ for Apple #112

Closed
wants to merge 1 commit into from

Conversation

barracuda156
Copy link
Contributor

Use the correct declaration on macOS.

@michaelonken
Copy link
Member

Thanks Sergey,

did you try this out? I could find old references that it is required to explicitly define environ this way so I wonder whether this is still required and works on "all" Apple systems.

Thanks!

@barracuda156
Copy link
Contributor Author

@michaelonken Yes, this way works across the board, which can be seen from a number of ports on buildbots; and CI pass for the latest macOS versions specifically for this one with the fix applied: macports/macports-ports#27063

I am not sure of the exact threshold when macOS started handling a Linux declaration for environ, but it does fail at least on some.

@michaelonken
Copy link
Member

Merged into upstream with f4d877 (visible on public muster branch within the next days).

@barracuda156 barracuda156 deleted the environ branch December 17, 2024 07:39
@barracuda156
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants