fix(source): change templates to include required fields

- holding institution and shelfmark fields are now required - fixes incorrect use of <small> tag on these fields
DDMAL · Aug 23, 2024 · c7f760c · c7f760c
1 parent 5e72103
commit c7f760c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/django/cantusdb_project/main_app/templates/source_create.html b/django/cantusdb_project/main_app/templates/source_create.html
@@ -45,21 +45,21 @@ <h3>Create Source</h3>
             <form method="post" style="line-height: normal">{% csrf_token %}
                 <div class="form-row">
                     <div class="form-group m-1 col-lg-3">
-                        <label for="{{ form.holding_institution.id_for_label }}">
-                            <small>Holding Institution:</small>
+                        <label for="{{ form.holding_institution.id_for_label }}" class="form-control-sm">
+                            Holding Institution:<span class="text-danger" title="This field is required">*</span>
                         </label>
-                        <br>{{ form.holding_institution }}
+                        {{ form.holding_institution }}
                         <p class=text-muted>
                             <small>{{ form.holding_institution.help_text }}</small>
                         </p>
                     </div>
                 </div>
                 <div class="form-row">
                     <div class="form-group m-1 col-lg-3">
-                        <label for="{{ form.shelfmark.id_for_label }}">
-                            <small>Shelfmark:</small><span class="text-danger" title="This field is required">*</span></small>
+                        <label for="{{ form.shelfmark.id_for_label }}" class="form-control-sm">
+                            Shelfmark:<span class="text-danger" title="This field is required">*</span>
                         </label>
-                        <br>{{ form.shelfmark }}
+                        {{ form.shelfmark }}
                         <p class=text-muted>
                             <small>{{ form.shelfmark.help_text }}</small>
                         </p>

diff --git a/django/cantusdb_project/main_app/templates/source_edit.html b/django/cantusdb_project/main_app/templates/source_edit.html
@@ -47,21 +47,21 @@ <h3>
     <form method="post" style="line-height: normal">{% csrf_token %}
         <div class="form-row">
             <div class="form-group m-1 col-lg-3">
-                <label for="{{ form.holding_institution.id_for_label }}">
-                    <small>Holding Institution:</small>
+                <label for="{{ form.holding_institution.id_for_label }}" class="form-control-sm">
+                    Holding Institution:<span class="text-danger" title="This field is required">*</span>
                 </label>
-                <br>{{ form.holding_institution }}
+                {{ form.holding_institution }}
                 <p class=text-muted>
                     <small>{{ form.holding_institution.help_text }}</small>
                 </p>
             </div>
         </div>
         <div class="form-row">
             <div class="form-group m-1 col-lg-3">
-                <label for="{{ form.shelfmark.id_for_label }}">
-                    <small>Shelfmark:</small><span class="text-danger" title="This field is required">*</span></small>
+                <label for="{{ form.shelfmark.id_for_label }}" class="form-control-sm">
+                    Shelfmark:<span class="text-danger" title="This field is required">*</span>
                 </label>
-                <br>{{ form.shelfmark }}
+                {{ form.shelfmark }}
                 <p class=text-muted>
                     <small>{{ form.shelfmark.help_text }}</small>
                 </p>