Add GitHub action to run tests; fix erroring test for ChantEditSyllabificationView #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag was introduced in v1.1.0 of volpiano-display-utilities
dchiller
force-pushed
the
add-test-runner
branch
from
34d6530
to
adacdb4
Compare
dchiller
force-pushed
the
add-test-runner
branch
from
eea298a
to
226cb5b
Compare
dchiller
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GitHub action that will run the django test suite when a PR is opened or new commits are pushed.
It also fixes an error in the
ChantEditSyllabificationView. Version 1.1.0 of volpiano-display-utilties introduced an additional output to thesyllabify_textfunction, which was not accounted for in the view.Finally, during the course of fixing these issues, I ran into a build error having to do with how
psycopg-binarywas specified inpyproject.toml. With this PR, a specific version of that package is specified.Closes #1524. Closes #1525.