Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send portions of sidebar to top on narrow screens; fix global search bar on dynamic pages #1537

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

dchiller
Copy link
Contributor

@dchiller dchiller commented Jun 17, 2024

Closes #1419. Closes #849. Closes #909. This PR introduces some new styling for pages where we have a two-column layout with a wider left column that contains the main content of the page and then a smaller right "sidebar" with one or many cards. The current homepage, articles page, and chant detail page are good examples of this:

image
image
image

This PR allows some upper portions of the sidebar to jump above the main content on a narrow window and the remainder to jump below the main content. The PR introduces this styling in a new template, base_page_with_side_cards.html, that other templates with this format can extend. This PR completes that refactoring for flat pages, pages in the articles app, and pages in main_app. Screenshots of the same three pages above with these styling changes are included here (in narrow format):

image
image
image

Closes #1532. I found a bug whereby search results from the global search bar on dynamic pages (ie. pages that weren't flatpages) did not show beneath the search box. This PR changes some of the styling of used when populating those asynchronous search results.

Before
image

After
image

- removes styling from the listBox element
- changes styling on its parent, the chantsDiv element
@dchiller dchiller requested review from lucasmarchd01 and removed request for lucasmarchd01 June 17, 2024 15:58
- create a new template "base_page_with_side_cards.html" from which other
templates can inherit with styling to send some sidebar cards above main
page content and some below main page content on narrow windows
- adjust flatpages, article pages and main_app templates to use this
template
- get rid of independent, media-aware main-content margins (these
are now accounted for in the template)
@dchiller dchiller marked this pull request as ready for review June 17, 2024 16:20
@dchiller dchiller merged commit bcc3b21 into DDMAL:develop Jun 18, 2024
1 check passed
@dchiller dchiller deleted the modify-sidebar branch June 18, 2024 15:09
@dchiller dchiller mentioned this pull request Jul 12, 2024
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants