Send portions of sidebar to top on narrow screens; fix global search bar on dynamic pages #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removes styling from the listBox element - changes styling on its parent, the chantsDiv element
dchiller
requested review from
lucasmarchd01
and removed request for
lucasmarchd01
- create a new template "base_page_with_side_cards.html" from which other templates can inherit with styling to send some sidebar cards above main page content and some below main page content on narrow windows - adjust flatpages, article pages and main_app templates to use this template - get rid of independent, media-aware main-content margins (these are now accounted for in the template)
lucasmarchd01
approved these changes
Jun 18, 2024
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1419. Closes #849. Closes #909. This PR introduces some new styling for pages where we have a two-column layout with a wider left column that contains the main content of the page and then a smaller right "sidebar" with one or many cards. The current homepage, articles page, and chant detail page are good examples of this:
This PR allows some upper portions of the sidebar to jump above the main content on a narrow window and the remainder to jump below the main content. The PR introduces this styling in a new template,
base_page_with_side_cards.html, that other templates with this format can extend. This PR completes that refactoring for flat pages, pages in thearticlesapp, and pages inmain_app. Screenshots of the same three pages above with these styling changes are included here (in narrow format):Closes #1532. I found a bug whereby search results from the global search bar on dynamic pages (ie. pages that weren't flatpages) did not show beneath the search box. This PR changes some of the styling of used when populating those asynchronous search results.
Before
After
