Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to reassign feast data and update chants #1564

Merged
merged 5 commits into from
Jul 17, 2024

Conversation

lucasmarchd01
Copy link
Contributor

Adds a management command that will transfer data between feasts and update chants accordingly.

  • Ensure data from old feasts are transferred to new feasts
  • Update chants and sequences to use new feast IDs
  • Delete old feasts after reassignment

Towards #1560, once we run the command on production we can close the issue.

- Ensure data from old feasts are transferred to new feasts
- Update chants and sequences to use new feast IDs
- Delete old feasts after reassignment
- add_prefix management command no longer exists
Copy link
Contributor

@dchiller dchiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! My only thought would be to make the old feast, new feast parameters into command line arguments.

On the plus side, that would mean you could use this command additionally where needed without having to go through the review process of getting a change to the code merged.

On the minus side, maybe we want that kind of review for something that makes these kinds of bulk changes. Also this way we have a record of past "feast merges".

Ok, I think the way you did it was better!

@lucasmarchd01
Copy link
Contributor Author

On the plus side, that would mean you could use this command additionally where needed without having to go through the review process of getting a change to the code merged.

On the minus side, maybe we want that kind of review for something that makes these kinds of bulk changes. Also this way we have a record of past "feast merges".

Good points! You're right, it's probably safest to have a review process for reassigning feasts. But I'll make the mapping a global variable for readability/modification in the future.

@lucasmarchd01 lucasmarchd01 merged commit a1ec9f7 into DDMAL:develop Jul 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants