Further fixes for institution migration #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the 'title' and 'siglum' fields read-only in the admin interface. Since they have already been removed from the other editing forms, this means there is no practical way of editing these values. This effectively makes them read-only until they are dropped (there was a request to keep them around for a little while.)
The XX-NN siglum (Unknown) has a RISM Online record, so it should be attached like the others.
lucasmarchd01
approved these changes
Jul 19, 2024
Comment on lines
+31
to
34
| readonly_fields = ("title", "siglum") + READ_ONLY + ( | ||
| "number_of_chants", | ||
| "number_of_melodies", | ||
| "date_created", |
There was a problem hiding this comment.
Suggested change
| readonly_fields = ("title", "siglum") + READ_ONLY + ( | |
| "number_of_chants", | |
| "number_of_melodies", | |
| "date_created", | |
| readonly_fields = READ_ONLY + ( | |
| "title", | |
| "siglum", | |
| "number_of_chants", | |
| "number_of_melodies", | |
| "date_created", |
There was a problem hiding this comment.
I did it this way so that title and siglum appear at the top of the read-only field block
dchiller
approved these changes
Jul 20, 2024
67 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a couple small changes in support of the institution migration.