Add indexing notes search to chant search page #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ChantSearchMSView: add filtering by indexing notes to the queryset - chant_search.html: add indexing notes search option in the form - chant_search.js: implement form logic for indexing notes search options
- ChantSearchMSView: add filtering by indexing notes to the queryset - chant_search.html: add indexing notes search option in the form - chant_search.js: implement form logic for indexing notes search options
…into issue-843
lucasmarchd01
changed the title
dchiller
approved these changes
Jul 29, 2024
| # the operation parameter can be "contains" or "starts_with" | ||
| if operation == "contains": | ||
| indexing_notes_filter = Q(indexing_notes__icontains=notes) | ||
| else: |
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh, you're right. I completely forgot about that issue. #1484 is concerned with the actual parameter values themselves, for example if a user inputs a string type value for an expected int type. In this case, the expected value can be anything, since we are doing a text search.
I copied this logic from another part of the code and did some testing, I don't think we'll encounter the 500 error here.
There was a problem hiding this comment.
Ok, great! I'm good to merge
67 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to the chant search page by adding the ability to search for keywords in the indexing notes of a chant. This feature is available only on the "searching in source" page. It was a relatively new feature on Old Cantus, which is why it was probably missed when re-building the new site.
Resolves #843