Update URLs, models, codebase, and admin pages to use "service" instead of "office" #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use 'service' instead of 'office'. - change all URL paths to use 'service/services'. DDMAL#1401 - create redirects to ensure backwards compatibility with old 'office/offices' URLs. DDMAL#1401 - update query parameters to use 'service' instead of 'office'. DDMAL#1401 - rename the Office model to Service. DDMAL#1402 - rename .office property of BaseChant to .service. DDMAL#1402 - change all instances of 'office' to 'service' in the codebase. DDMAL#1402 - update all references to 'office' to 'service' on the Django admin pages. DDMAL#1581
dchiller
approved these changes
Aug 7, 2024
- fix corresponding tests from status code 302 to 301
This was referenced Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the need for consistency in our URL paths, models, and properties by changing all references from 'office/offices' to 'service/services'.
Changes
URL Paths:
Query Parameters:
Models and Properties:
Officemodel toService..officeproperty ofBaseChantto.service.Django Admin:
Note: the genre list page https://cantusdatabase.org/genres/ has been left as is until we decide whether to change "Mass / Office" to "Mass / Service"
Resolves #1401, Resolves #1402, Resolves #1581