Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nginx configuration and switch to runserver_plus in devcontainer setup #1599

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

lucasmarchd01
Copy link
Contributor

@lucasmarchd01 lucasmarchd01 commented Aug 14, 2024

This change disables nginx's error page interception for the development environment configuration file to ensure that Django's debug pages are displayed correctly when DEBUG is set to True. I think that this change was introduced as part of #1530 which should be done instead on the cantusdb.conf file on the production server. (Related: #1598)

Replaced runserver with runserver_plus in the Docker Compose configuration for the development container.

@dchiller
Copy link
Contributor

Good catch on the proxy_intercept_errors. I made the change in development (where you're right, it shouldn't be) but never actually did it in the playbooks :(

Made a PR for that here: https://github.com/dact-chant/ansible.cantus-db/pull/48

@lucasmarchd01 lucasmarchd01 merged commit 9718dff into DDMAL:develop Aug 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants