Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make shelfmark a required field on source create and edit forms #1606

Merged
merged 9 commits into from
Aug 30, 2024
Merged

Make shelfmark a required field on source create and edit forms #1606

merged 9 commits into from
Aug 30, 2024

Commits on Aug 19, 2024

  1. fix(source): fix TypeError on source create page 

    - make shelfmark a required field on source create and edit pages
    @lucasmarchd01
    lucasmarchd01 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ec8a851 View commit details
    Browse the repository at this point in the history

  2. fix(source): fix TypeError on source create page 

    - make shelfmark a required field on source create and edit pages
- make shelfmark a required field on admin source add form
    @lucasmarchd01
    lucasmarchd01 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c49eb51 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'issue-1604' of https://github.com/lucasmarchd01/CantusDB … 

    …into issue-1604
    @lucasmarchd01
    lucasmarchd01 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    7a714b0 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. fix(source): make holding institution and shelfmark fields required 

    - in source model
- on the source create and edit forms
    @lucasmarchd01
    lucasmarchd01 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    5e72103 View commit details
    Browse the repository at this point in the history

  2. fix(source): change templates to include required fields 

    - holding institution and shelfmark fields are now required
- fixes incorrect use of <small> tag on these fields
    @lucasmarchd01
    lucasmarchd01 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c7f760c View commit details
    Browse the repository at this point in the history

  3. test(source): fix failing tests in SourceEditViewTest and SourceCreat… 

    …eViewTest

- add holding institution required field
    @lucasmarchd01
    lucasmarchd01 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    86d22c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Merge branch 'develop' into issue-1604

    @lucasmarchd01
    lucasmarchd01 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ec7ac99 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. new: add migration script for non-nullable fields

    @lucasmarchd01
    lucasmarchd01 committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    c69f53a View commit details
    Browse the repository at this point in the history

  2. style: black formatting changes

    @lucasmarchd01
    lucasmarchd01 committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    d39d486 View commit details
    Browse the repository at this point in the history