Merge develop into staging, 30 Aug 2024 #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update nginx configuration and switch to `runserver_plus` in devcontainer setup
Fix `FieldError` on admin user change page
Change help text for `date` field on source edit page
- view: add 'countries' context and add country filter to query object filter - html: add countryFilter dropdown to 'Browse Sources' page - js: ensure countryFilter persists across multiple GET requests - test: add tests for country filter
- make shelfmark a required field on source create and edit pages
- make shelfmark a required field on source create and edit pages - make shelfmark a required field on admin source add form
…into issue-1604
Add country filter to source list page
The JSONResponseMixin reimplements the render_to_result method on generic DetailViews and ListViews to check for the request's Accept header. If the Accept header is "application/json" then json for the object or list of objects is provided. If not, renders the template as usual.
…vice views - Uses the JSONResponseMixin to return JSON results in appropriate places for the GenreList, GenreDetail, ServiceList, and ServiceDetail views. - Adds appropriate tests for the JSON response - Refactors some relevant tests to more efficiently create and use fake objects - Allows all aspects of a fake genre to be set with the make_fake_genre function
Adds functionality to `db_backup.sh` and `postgres_backup.sh` to create a weekly backup of some tables in the database for RISM's use. user, auth, and reversion tables are not included. The backup is added to the backup directory (defined in ansible deployment) in the `rism` subdirectory.
in response to e-mail feedback
Adds functionality for private collection and for migrated identifiers
- in source model - on the source create and edit forms
- holding institution and shelfmark fields are now required - fixes incorrect use of <small> tag on these fields
…eViewTest - add holding institution required field
Create partial database backup for RISM
Institution fixes
Create JSON endpoint for `Service` and `Genre` list and detail views
- Add sortable "city + institution" column - Make source column = siglum + shelfmark - Make default order siglum + shelfmark
Newer versions of faker are now typed and have identical functionality in the ways we need it.
We use the same structure as in the views themselves.
|
Sounds good! I'll review the rest of the PR's now. |
Break up `test_views.py` so structure matches views directory
Revert "Break up `test_views.py` so structure matches views directory"
Adjust sortable columns for source list page (based on email feedback)
Add zoom links to link checker exclusions
Display chant.project on Chant Detail page where it exists
Make `shelfmark` a required field on source create and edit forms
We use the same structure as in the views themselves.
|
@lucasmarchd01 Good to go now? |
Yup, I think so! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to update staging again before I do another data migration test to our new source/institution identification models.