Institution source changes #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for the description of colloquial names for sources
Allows for the capture of other identifiers for a source.
lucasmarchd01
approved these changes
Sep 16, 2024
| # required=True, | ||
| # widget=TextInputWidget, | ||
| # help_text="RISM-style siglum + Shelf-mark (e.g. GB-Ob 202).", | ||
| # ) |
There was a problem hiding this comment.
If we aren't planning on reintroducing these fields in the admin form (I see currently they're read only in the admin page) then we can probably remove this comment.
Is the idea that eventually we will remove title and siglum data all together?
There was a problem hiding this comment.
Yeah, I guess I’m just hedging my bets here, waiting for someone to ask “but wait, where did the siglum field go” (and then another 128 emails follow ;-)
dchiller
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the outstanding issues that were brought out in our e-mail conversations: