Fix files so that they are validated by the schema #15
Conversation
Also add comments to scripts
|
I'm confused by the diff of this PR. Why are 2000 + files changed to fix #8? |
It would be a good idea to put whatever issues these were into an issue and/or in the description of this PR: what would another developer need to know about what changes were made with this PR and why? |
| for att in list(child.attrib): | ||
| if att.endswith("href"): | ||
| child.attrib['target'] = child.attrib.pop(att) |
There was a problem hiding this comment.
It seems counterintuitive to me to iterate through the child attributes to get a single attribute?
Why not child.get("href") (maybe you have to namespace it)?
There was a problem hiding this comment.
iteration is used to avoid problems with namespace
There was a problem hiding this comment.
Are the namespaces of the liber MEI 3 files inconsistent?
There was a problem hiding this comment.
Sometimes the namespace shows up, sometimes it doesn't
There was a problem hiding this comment.
Like, different mei3 files will have different namespaces?
Do you have an example?
There was a problem hiding this comment.
I just ran a script to print out every unique attribute of the files. One attribute has {http://www.w3.org/1999/xlink} as a namespace, one has {http://www.w3.org/XML/1998/namespace}, the remaining have no namespace. I can look into removing the iteration for attributes with no namespace
| label = "" | ||
| for attr, value in child.attrib.items(): | ||
| if attr.endswith("ulx") and int(value) < 0: | ||
| child.attrib["label"] = label + "ulx = " + value + " " |
There was a problem hiding this comment.
So on zone elements, you are setting the label attribute to "ulx = some_number " ? The label attribute looks like is designed for a tooltip or some such?
Why not use the Element.set method here?
There was a problem hiding this comment.
Code rewritten to use child.set
The label attribute here is used when ulx or lrx is negative to save their original values
There was a problem hiding this comment.
Is that necessary? We are saving the original files if we ever need those values and it seems to me we should be trying to have the MEI v5 files created be "up to code".
There was a problem hiding this comment.
label attribute removed
|
Could you link the relevant issues to this PR? |
| for child_2 in root.iter(): | ||
| for attr, value in child_2.attrib.items(): | ||
| if attr.endswith("id") and value == pageref: | ||
| child.set("n", child_2.attrib["n"]) | ||
| break |
There was a problem hiding this comment.
This could be a find call, rather than iterating through the whole tree again:
root.find(".//meins:page[@xmlns:id='pageref']", namespaces = ...)| child.tag = "TODELETE" | ||
|
|
||
| # Handle system breaks | ||
| elif child.tag.endswith("sb"): |
There was a problem hiding this comment.
Same questions in this block as in the block about "pb"
| label = "" | ||
| for attr, value in child.attrib.items(): | ||
| if attr.endswith("ulx") and int(value) < 0: | ||
| label = f"{label} ulx = {value} " |
There was a problem hiding this comment.
Your label attribute will now always have a leading and trailing space if not empty...this doesn't seem right.
There was a problem hiding this comment.
Label has been removed
Also label removed from zone
Also simplify attribute0-handling code for most attributes
- Neume components no longer just puntum - Fix bug that removed content from elements - new liberbatch_parr.py script that takes advantage of parallel processing - MEI files output with proper indentation
Also fix octave glitch that arises when notationtype is set to neume
Scripts were used to update already-generated mei 5 files, now incorporated into larger liberupdatev5
|
@CThierrin It's very hard to review given the number of files in the PR (my browser gets really slow trying to render the diffs). Could you make a PR that just has the new MEI files and then have this PR be the changes to the code files... I don't think the MEI files themselves need my review, and then I'll be able to review the code here. |
|
@dchiller The new MEI files can just get deleted, they need to be remade again |
Also add dimensions to files
Resolves #8, resolves #12, and resolves #13, and adds comments to scripts