Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Liber Usualis images to repository #20

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

CThierrin
Copy link
Contributor

Resolves issue #19
Also update Readme to better explain the images

Also updated readme to better explain the images
@CThierrin CThierrin requested a review from dchiller August 2, 2024 19:48
@dchiller
Copy link
Contributor

dchiller commented Aug 5, 2024

@CThierrin I can't review the files because there are too many/they are too large. I assume they are mostly the image files?

I'm ok with this as long as we also put the images in Arbutus Object Storage, which is where we've historically added image files. There are instructions for this in the wiki.

@CThierrin
Copy link
Contributor Author

@CThierrin I can't review the files because there are too many/they are too large. I assume they are mostly the image files?

I'm ok with this as long as we also put the images in Arbutus Object Storage, which is where we've historically added image files. There are instructions for this in the wiki.

They are indeed image files. I'll look into adding the images to Arbutus

@dchiller
Copy link
Contributor

dchiller commented Aug 6, 2024

Ok, I literally can't add a review, so you can consider this comment my "approval".

@dchiller dchiller merged commit ae8849e into main Aug 9, 2024
@dchiller dchiller deleted the Add-images-for-liber-usualis branch August 9, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants