Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link checker for testing #1027

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Add link checker for testing #1027

merged 2 commits into from
Jun 16, 2023

Conversation

zhannaklimanova
Copy link
Contributor

@zhannaklimanova zhannaklimanova commented Jun 15, 2023

Adding github actions code for checking broken links on the main page of Neon. Because this is an application website, only the ones on that page can be checked without recursively going into other websites which have their own link checkers. The overall output of the link checker for Neon should look like what I put below, but all the working links (├───OK───) are filtered out with the awk command to leave only the ones having an HTTP_404 as they are the most useful. Link checker fails the actions if there is even one HTTP_404, this failure is totally fine and expected. The actions will pass as soon as the link to https://www.computecanada.ca/home/ is fixed (the link is located in a div with id=sponsors-and-partners-container; image at bottom).

Unfiltered output of link checker:
Getting links from: https://ddmal.music.mcgill.ca/Neon/
├───OK─── https://ddmal.music.mcgill.ca/Neon/favicon.ico
├───OK─── https://github.com/DDMAL/Neon/wiki
├───OK─── https://ddmal.music.mcgill.ca/Neon/css/default-styles.css
├───OK─── https://simssa.ca/
├───OK─── http://www.sshrc-crsh.gc.ca/
├─BROKEN─ https://www.computecanada.ca/home/ (HTTP_404)
├───OK─── https://cdnjs.cloudflare.com/ajax/libs/d3/5.10.0/d3.min.js
├───OK─── http://www.cirmmt.org/
├───OK─── https://ddmal.music.mcgill.ca/Neon/css/homepage.css
├───OK─── http://www.frqsc.gouv.qc.ca/
├───OK─── https://www.westgrid.ca/
├───OK─── https://docs.google.com/forms/d/e/1FAIpQLSfspol99BxJmIuZuSO-dVFDoo_absttgAo7czk9ecqDT4uF1A/viewform
├───OK─── https://ddmal.music.mcgill.ca/
├───OK─── https://ddmal.music.mcgill.ca/Neon/Neon-gh/assets/img/Neon-Icon.svg
├───OK─── https://ddmal.music.mcgill.ca/Neon/dashboard.html
├───OK─── https://github.com/DDMAL/Neon
├───OK─── https://ddmal.music.mcgill.ca/Neon/Neon-gh/assets/img/generic-profile-picture.svg
├───OK─── https://ddmal.music.mcgill.ca/Neon/Neon-gh/assets/img/logos.png
├───OK─── https://www.mcgill.ca/music
├───OK─── http://ddmal.music.mcgill.ca/
├───OK─── https://ddmal.music.mcgill.ca/Neon/Neon-gh/assets/img/Neon-logo.svg
├───OK─── https://ddmal.music.mcgill.ca/Neon/Neon-gh/assets/img/github-icon.svg

image

@zhannaklimanova zhannaklimanova force-pushed the broken-link-checker branch 3 times, most recently from 467df5b to 1c0e0b5 Compare June 15, 2023 03:36
Copy link
Contributor

@cadagong cadagong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@zhannaklimanova zhannaklimanova merged commit 943c792 into develop Jun 16, 2023
3 checks passed
@zhannaklimanova zhannaklimanova self-assigned this Jun 16, 2023
@zhannaklimanova zhannaklimanova linked an issue Jun 16, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate broken link checker into a Github Actions step
3 participants