Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💄 UI responsiveness fixes #1032

Merged
merged 10 commits into from
Jul 5, 2023
Merged

💄 UI responsiveness fixes #1032

merged 10 commits into from
Jul 5, 2023

Conversation

cadagong
Copy link
Contributor

  • 💄 Update styles for the content inside the pancake menu, which appears only on smaller devices (1023 pixels wide and smaller). The menu was completely unusable on devices with a width of under 900 pixels, and some buttons were never visible on devices between 900 and 1023 pixels wide.
  • 💡 Remove commented-out CSS and update comments inside style.css

@cadagong
💄 UI fix for pancake menu on smaller devices.
100851e 
- Fix UI for content inside pancake menu for devices with screens that are under 1024px in width.
- Add 'alt' attribute for 'saved-icon' and 'unsaved-icon' SVGs in order to display descriptive text of the image in case resource doesn't load.
@cadagong
💡 Remove commented out CSS, Update style.css comments
11d5543
@cadagong cadagong requested a review from yinanazhou June 22, 2023 13:22
@yinanazhou yinanazhou merged commit be24011 into develop Jul 5, 2023
3 checks passed
@yinanazhou yinanazhou mentioned this pull request Jul 5, 2023
Closed
@yinanazhou yinanazhou deleted the UI-responsiveness-fixes branch August 4, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yinanazhou yinanazhou yinanazhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cadagong @yinanazhou