Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate verovio prod and dev #1228

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Separate verovio prod and dev #1228

merged 2 commits into from
Jun 25, 2024

Conversation

yinanazhou
Copy link
Member

  • Remove customized external verovio module (setup-verovio, verovio-util/)
  • Update webpack config, yarn.lock, package.json
  • Introduce verovio worker for development
  • Use wasm verovio for development (webpack.config.js)
  • Load from verovio website for production (webpack.pages-config.js)
  • Remove redundant webpack.dev.config.js

@yinanazhou
build!: remove external and use wasm verovio
ba92337 
- remove customized external verovio module (setup-verovio, verovio-util/)
- update webpack config, yarn.lock, package.json
- use `wasm` verovio toolkit
- introduce verovio worker for development

Resolves: #1221
@yinanazhou
build!: separate verovio for prod and dev
d418622 
- Use `wasm` verovio for development (`webpack.config.js`)
- Load from verovio website for production (`webpack.pages-config.js`)
- Remove redundant `webpack.dev.config.js`

Resolves: #1219, #1221
@yinanazhou yinanazhou merged commit b860650 into neume-line Jun 25, 2024
3 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yinanazhou