Request: Allow user to delete individual resources without having to delete their workflow run first #996
Comments
|
After further investigation this seems like a pure rodan-client, frontend issue. I found that the Delete button is indeed disabled if there's a workflow run attached to it. This is in |
|
It appears that this is not only a frontend issue. Deletion of resources is protected in the backend model so raises an exception if the user tries to delete a resource without deleting the associated workflow run. We could remove the protection but it also seems like deleting resources from workflow runs could be potentially problematic. For example, what if a resource was deleted while the workflow is running? |
|
Would it be possible to enable deleting a resource only when the workflow run is finished? (Sorry if this is a dumb question.) If not, I think the most useful thing anyway would be for a workflow run's resources to delete when the workflow run is deleted. That alone would save a lot of time! |
|
I took a deeper look at the code and I think it is possible to do this theoretically, but it seems that it might not be worth it as there would be a lot of concerns and edge cases to consider (including workflow cancellation, retrying, redoing run job tree, etc.). I am also not sure if it makes sense to keep around workflow runs with arbitrary missing resources. If it is not that important, I propose that we leave out this feature in favour of automatically deleting resources when workflow runs are deleted. |
|
Related to this, when you want to delete a workflow or workflow run the button immediately visible is the 'delete project' button, which makes it very easy to accidentally nuke your project while trying to delete a messed up workflow. Possible to either move it nearer to project label, or add a popup window asking user to confirm if they want to delete whole project? |
|
@kyrieb-ekat I made an issue about that a while ago when that exact thing happened to me: #1079! It was a difficult time. |
|
Oh word!! I'm sorry, I must not have seen it, my bad! Yeah I fully deleted my project once and even then almost accidentally did it again (whups...). |
When in the "Resources" list, the option to delete an individual resource is not available--the button "Delete" just isn't clickable. If a user wants to delete a resource, they have to:
Demo (wherein you can see that I can't delete the resource at first; it only works when I delete the workflow run):
Resource.deletion.process.mov
I have two requests related to this:
I think both these things would save users' time, and also be more intuitive.
The text was updated successfully, but these errors were encountered: