Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete generated resources when workflow run is deleted #1007

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Delete generated resources when workflow run is deleted #1007

wants to merge 2 commits into from

Conversation

jackyyzhang03
Copy link
Contributor

@jackyyzhang03 jackyyzhang03 commented Jul 5, 2023 •
edited
Loading

Resolves: (#996)

  • I passed the docker hub test, and images can be built successfully.
  • I passed the GitHub CI test, so rodan functionalities and jobs work.

(Describe the changes you've made and the purpose of this PR)

  • Add post_delete listener to delete resources when their associated workflow run is deleted
  • Show confirmation dialog when users are deleting a workflow run

@jackyyzhang03 jackyyzhang03 changed the base branch from master to develop July 5, 2023 15:42
@jackyyzhang03 jackyyzhang03 force-pushed the jacky/delete-generated-resources-when-deleting-workflow branch from f7098b1 to 26d0b16 Compare July 5, 2023 15:43
@jackyyzhang03 jackyyzhang03 linked an issue Jul 5, 2023 that may be closed by this pull request
Request: Allow user to delete individual resources without having to delete their workflow run first #996
Open
@jackyyzhang03 jackyyzhang03 marked this pull request as ready for review July 5, 2023 16:41
@jackyyzhang03 jackyyzhang03 force-pushed the jacky/delete-generated-resources-when-deleting-workflow branch from 26d0b16 to a1a3ed0 Compare July 7, 2023 14:41
@jackyyzhang03 jackyyzhang03 force-pushed the jacky/delete-generated-resources-when-deleting-workflow branch from a1a3ed0 to 1641d51 Compare July 7, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cadagong cadagong Awaiting requested review from cadagong

@malajvan malajvan Awaiting requested review from malajvan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Allow user to delete individual resources without having to delete their workflow run first
1 participant
@jackyyzhang03