Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust modal window grid and fix scroll #1150

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

yinanazhou
Copy link
Member

@yinanazhou yinanazhou commented May 23, 2024

Resolves: #1146

  • I passed the docker hub test, and images can be built successfully.
  • I passed the GitHub CI test, so rodan functionalities and jobs work.
  1. use fr unit for grid-template-columns
  2. make only tbody scroll on overflow

Copy link

@homework36 homework36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally on my machine

@yinanazhou yinanazhou merged commit 9412fe4 into develop May 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants