Change default octave for clefs in heuristic pitch finding #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchiller
reviewed
Sep 16, 2024
rodan-main/code/rodan/test/files/238r-heuristic_pitch_finding.json
Outdated
Show resolved
Hide resolved
rodan-main/code/rodan/jobs/heuristic_pitch_finding/PitchFinding.py
Outdated
Show resolved
Hide resolved
- add new ground truth file for job test
…nto fix-default-octave
dchiller
approved these changes
Sep 20, 2024
|
I tested locally. Everything is great. |
homework36
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves DDMAL/heuristic_pitch_finding#12
This fix addresses an issue with octave calculation in the
PitchFinding.pyfile, where the octave was being calculated incorrectly for C clefs. The algorithm previously treated all non-C clefs as positioned above the C clef, which caused incorrect default octave in the MEI file output.Introduced a
clef_octave_mapto define canonical base octaves for C, F, and G clefs. This fix simplifies the handling of clefs, focusing only on C, F, and G clefs as they are the primary use cases.Also fixed logger import.