Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable email notifications #971

Merged
merged 8 commits into from
Jul 7, 2023
Merged

Enable email notifications #971

merged 8 commits into from
Jul 7, 2023

Conversation

jackyyzhang03
Copy link
Contributor

@jackyyzhang03 jackyyzhang03 commented Jun 15, 2023 •
edited
Loading

Resolves: (#962, #964, #966)

  • I passed the docker hub test, and images can be built successfully.
  • I passed the GitHub CI test, so rodan functionalities and jobs work.

(Describe the changes you've made and the purpose of this PR)

  • Enable email notifications for workflow run status updates (completion, failure, waiting for input), password change, and when added as admin or worker to a project

@jackyyzhang03 jackyyzhang03 force-pushed the jacky/enable-email-notifications branch from 5beb053 to 90ef30b Compare June 16, 2023 16:06
This was linked to issues Jun 16, 2023
Send email notifications when workflow runs are completed #962
Closed
Email on password change #964
Closed
Email notification for project collaboration #966
Closed
@jackyyzhang03 jackyyzhang03 marked this pull request as ready for review June 19, 2023 19:59
@jackyyzhang03 jackyyzhang03 force-pushed the jacky/enable-email-notifications branch from 88b0f4c to d13136d Compare June 20, 2023 13:58
@jackyyzhang03 jackyyzhang03 marked this pull request as draft June 20, 2023 13:59
@jackyyzhang03 jackyyzhang03 force-pushed the jacky/enable-email-notifications branch from d13136d to 8d45644 Compare June 20, 2023 14:12
@jackyyzhang03 jackyyzhang03 linked an issue Jun 20, 2023 that may be closed by this pull request
Email password recovery #963
Closed
@jackyyzhang03 jackyyzhang03 force-pushed the jacky/enable-email-notifications branch 2 times, most recently from 1414a96 to fe72e38 Compare June 23, 2023 15:08
@jackyyzhang03 jackyyzhang03 removed a link to an issue Jun 23, 2023
Email password recovery #963
Closed
@jackyyzhang03 jackyyzhang03 marked this pull request as ready for review June 23, 2023 15:14
malajvan
malajvan requested changes Jun 27, 2023
View reviewed changes
scripts/local.env Show resolved Hide resolved
@malajvan malajvan self-requested a review June 30, 2023 15:17
malajvan
malajvan approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@malajvan malajvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackyyzhang03 jackyyzhang03 force-pushed the jacky/enable-email-notifications branch from 561ed98 to 077c5b8 Compare July 4, 2023 13:49
@jackyyzhang03 jackyyzhang03 mentioned this pull request Jul 4, 2023
Merged
2 tasks
@jackyyzhang03 jackyyzhang03 force-pushed the jacky/enable-email-notifications branch from df201f7 to 077c5b8 Compare July 4, 2023 14:54
@jackyyzhang03 jackyyzhang03 force-pushed the jacky/enable-email-notifications branch from 077c5b8 to e39afb1 Compare July 7, 2023 14:42
@jackyyzhang03 jackyyzhang03 merged commit c49325f into develop Jul 7, 2023
@malajvan malajvan deleted the jacky/enable-email-notifications branch August 23, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malajvan malajvan malajvan approved these changes

@sabrina0822 sabrina0822 Awaiting requested review from sabrina0822

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jackyyzhang03 @malajvan