Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Calvo from Rodan #978

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Remove Calvo from Rodan #978

merged 1 commit into from
Jun 20, 2023

Conversation

sabrina0822
Copy link
Contributor

@sabrina0822 sabrina0822 commented Jun 20, 2023 •
edited by softcat477
Loading

Resolves: #979

  • I passed the docker hub test, and images can be built successfully.
  • I passed the GitHub CI test, so rodan functionalities and jobs work.

Remove calvo's classifier now that we have paco's method to simplify the GPU container and prevent conflicting requirements.

@sabrina0822 sabrina0822 linked an issue Jun 20, 2023 that may be closed by this pull request
Remove calvo classifier from Rodan #979
Closed
malajvan
malajvan approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@malajvan malajvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@softcat477 softcat477 merged commit 95ada60 into develop Jun 20, 2023
@sabrina0822 sabrina0822 deleted the remove-calvo branch July 4, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malajvan malajvan malajvan approved these changes

@softcat477 softcat477 softcat477 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove calvo classifier from Rodan
3 participants
@sabrina0822 @softcat477 @malajvan