Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove PORT environment variable #109

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

refactor: remove PORT environment variable #109

wants to merge 1 commit into from

Conversation

zhannaklimanova
Copy link
Contributor

closes #103

@dchiller
Copy link
Contributor

dchiller commented Jul 8, 2024 •
edited
Loading

This looks good to me.

Note that this also requires changes on the edge routers through the nginxconf ansible playbook here: https://github.com/DDMAL/Operations/blob/653e9cb742c261bd1a234e26728eee8274de1bd7/playbooks/vars/simssa.ca.yml#L47-L49, so deployment of this change should be coordinated with that. (This link is to prod UMIL, but there is an analogous spot for staging UMIL).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchiller dchiller dchiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of PORT environment variable
2 participants
@zhannaklimanova @dchiller