-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update language list #158
Open
kunfang98927
wants to merge
2
commits into
develop
Choose a base branch
from
update-language-list
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update language list #158
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
58 changes: 45 additions & 13 deletions
58
web-app/django/VIM/apps/instruments/management/commands/import_languages.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,29 +1,61 @@ | ||
"""This module imports possible languages for instrument names from Wikidata.""" | ||
|
||
import requests | ||
from django.core.management.base import BaseCommand | ||
from VIM.apps.instruments.models import Language | ||
|
||
|
||
class Command(BaseCommand): | ||
""" | ||
The import_languages command populates the database with languages in which instrument | ||
names can be provided in VIM. | ||
|
||
NOTE: For now, this script only imports English and French. | ||
names can be provided in VIM. It fetches the language list from Wikidata, retrieves the | ||
'wikidata_code', 'wikidata_id', 'autonym', and 'en_label', and stores them in the database. | ||
""" | ||
|
||
help = "Imports possible languages for instrument names from Wikidata." | ||
|
||
WIKIDATA_SPARQL_URL = "https://query.wikidata.org/sparql" | ||
|
||
def handle(self, *args, **options): | ||
Language.objects.create( | ||
wikidata_code="fr", | ||
wikidata_id="Q150", | ||
en_label="french", | ||
autonym="français", | ||
query = """ | ||
SELECT ?language ?languageLabel ?ISO639code ?autonym WHERE { | ||
?language wdt:P31 wd:Q34770; # Instance of a natural language | ||
wdt:P424 ?ISO639code; # ISO 639 code | ||
rdfs:label ?autonym filter (lang(?autonym) = ?ISO639code). | ||
SERVICE wikibase:label { bd:serviceParam wikibase:language "en". } | ||
} | ||
""" | ||
|
||
headers = {"Accept": "application/sparql-results+json"} | ||
response = requests.get( | ||
self.WIKIDATA_SPARQL_URL, | ||
params={"query": query}, | ||
headers=headers, | ||
timeout=50, | ||
) | ||
Language.objects.create( | ||
wikidata_code="en", | ||
wikidata_id="Q1860", | ||
en_label="english", | ||
autonym="english", | ||
data = response.json() | ||
|
||
for item in data["results"]["bindings"]: | ||
wikidata_code = item["ISO639code"]["value"] | ||
wikidata_id = item["language"]["value"].split("/")[-1] | ||
en_label = item["languageLabel"]["value"] | ||
autonym = item["autonym"]["value"] | ||
|
||
self.stdout.write( | ||
wikidata_code, "-", wikidata_id, "-", en_label, "-", autonym | ||
) | ||
|
||
Language.objects.update_or_create( | ||
wikidata_code=wikidata_code, | ||
defaults={ | ||
"wikidata_id": wikidata_id, | ||
"en_label": en_label, | ||
"autonym": autonym, | ||
}, | ||
) | ||
|
||
self.stdout.write( | ||
self.style.SUCCESS( | ||
f"Successfully imported {len(data['results']['bindings'])} languages." | ||
) | ||
) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did this query come from? I suspect (given that it results in 253 languages) that these are all supported langauges for adding item names to Wikidata, but I'm curious how we know. Or are we not caring if they are supported in Wikidata? Either way, a little explanation of the "why" here would be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This query was generated by ChatGPT. I now realize that this query is not correct because many of the most common languages are missing. I add some solutions in the issue #157.