feat: sort and search by language/name on edit page #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support sort by language - Support sort by name - Support search by language Refs: #137
dchiller
reviewed
Sep 18, 2024
Comment on lines
+20
to
+25
|
|
||
| if search_query: | ||
| instrument_names = instrument_names.filter(language__en_label__icontains=search_query) | ||
|
|
||
| instrument_names = instrument_names.order_by(sort_by) | ||
| context["instrument_names"] = instrument_names |
There was a problem hiding this comment.
We have a solr set-up for UMIL... let's use that for search!
Lemme know if you want some examples for how to set this up.
There was a problem hiding this comment.
Yes, some example would be great!
There was a problem hiding this comment.
Ok, a few things would be helpful:
- The solr admin panel is location at port 8983 (so in development at localhost:8983). One of the more useful areas of this for debugging search applications is the
Querysection. In the drop-down on the left, you'll see thevirtual-instrument-museumcore. Select that one, and then in the panel that appears you can go toQueryto get a UI for making solr queries. Useful for debugging queries. - An example from Cantus Ultimus: we use this view to query solr to provide search suggestions: https://github.com/DDMAL/cantus/blob/main/app/public/cantusdata/views/suggestion.py. The view is pretty simple: building a request to the solr server and then making it with the requests package.
- I don't have an example of this, but if you wanted to perform the search without routing through a Django view, you could just make the request via Javascript to the solr server (eg. have the browser request to an endpoint that your route to the solr server using the nginx configurations and then unpack the json response in the client).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #137
Sort by Name
Sort by Language
Search by Language