Fix some UI issues #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put the number of instruments in each category in a bracket and place it after the category name
This was referenced Dec 1, 2023
dchiller
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Just a few questions, but looks good otherwise!
I am not sure I understand #96 , so at least @yinanazhou should review that too.
| localStorage.setItem("hideInstrumentBadge", true); | ||
| updateInstrumentBadge(); | ||
| }); | ||
| // // Instrument badge settings |
There was a problem hiding this comment.
Is there a reason you comment instead of delete?
There was a problem hiding this comment.
These are Yinan's codes, and these changes are for #96 . If she thinks these changes are okay, I will delete them.
| {{ active_language.autonym|title }} | ||
| <span id="instrument-language-badge" | ||
| {% comment %} <span id="instrument-language-badge" |
| @@ -196,4 +210,8 @@ <h4 class="ms-3 me-2 my-auto"><small>INSTRUMENT LIST</small></h4> | |||
| <script src="https://unpkg.com/imagesloaded@5/imagesloaded.pkgd.min.js"></script> | |||
| <script src="{% static "instruments/js/DisplaySettings.js" %}"></script> | |||
| <script src="{% static "instruments/js/PaginationTools.js" %}"></script> | |||
| <script> | |||
There was a problem hiding this comment.
Can this go in one of our static .js files?
There was a problem hiding this comment.
Sure, I'll fix this today.
|
Also just make sure to link the relevant issues or close them when this merges :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues #92 #93 #95 #96.
For #94, The configuration of sending emails has not been completed yet, the UI part has been completed.