Update Node.js to supported version #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the process of this update, gulp had to be upgraded to v4. run-sequence package was made irrelevant by the introduction of gulp.series in gulp v4. Reorganization of the gulpfile.js was required due to changes in task registration from gulp v3 to gulp v4 where gulp stopped allowing forward references in task registration.
This also required the upgrade of gulp-sass to v5. A compiler is no longer bundled with gulp-sass in v5, so sass had to be installed independently.
jacobdgm
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of this PR, the Node version with LTS is v18 (v20 is currently released but not yet "Active" -- an upgrade should be possible later this year). Closes #694.
Additionally, the version of the
nginxbase container pulled from Docker Hub is specified.Explanation of Changes
gulppackage had to be upgraded to version 4.gulpv4 made therun-sequencepackage obsolete. Instead, sequential tasks are registered usinggulp.series.gulpfile.jswas updated to include this change.gulpv4 no longer allowed forward references in task registration. Tasks needed to be registered before they could be included as dependencies in other tasks. The order of task registration ingulpfile.jswas modified to remove forward references.gulp-sasspackage had to be upgraded to version 5.gulp-sassby default. A compiler (in this casesass) had to be independently installed and passed togulp-sasswhen imported intogulpfile.js.