-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command for indexing MEI files in solr #848
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of the test core during testing is already defined in test/test_settings.py
dchiller
changed the title
Add command in index MEI files in solr
Add command for indexing MEI files in solr
May 15, 2024
lucasmarchd01
requested changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think some extra exception handling would ensure that the command will always run successfully.
app/public/cantusdata/management/commands/index_manuscript_mei.py
Outdated
Show resolved
Hide resolved
app/public/cantusdata/management/commands/index_manuscript_mei.py
Outdated
Show resolved
Hide resolved
app/public/cantusdata/management/commands/index_manuscript_mei.py
Outdated
Show resolved
Hide resolved
Great suggestions...I've push some changes that add exceptions at these places. |
ahankinson
reviewed
May 22, 2024
app/public/cantusdata/management/commands/index_manuscript_mei.py
Outdated
Show resolved
Hide resolved
lucasmarchd01
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to the re-implementation of MEI search in CU by adding the
index_manuscript_mei
command, which, given a manuscript ID, will parse and index the MEI for that manuscript in the solr index. The PR adds associated tests.This PR also:
production-mei-files
which tracks the production mei files repository which will be used to manage MEI files resulting from the OMR processimport_mei_data
command that was used for an older OMR-search process and is superseded by the new command