Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command for indexing MEI files in solr #848

Merged
merged 11 commits into from
May 22, 2024
Merged

Conversation

dchiller
Copy link
Collaborator

@dchiller dchiller commented Apr 16, 2024

This PR contributes to the re-implementation of MEI search in CU by adding the index_manuscript_mei command, which, given a manuscript ID, will parse and index the MEI for that manuscript in the solr index. The PR adds associated tests.

This PR also:

  • add a submodule production-mei-files which tracks the production mei files repository which will be used to manage MEI files resulting from the OMR process
  • changes location of test MEI files introduce in previous OMR-related commits (e.g. Update MEI parsing and creation of OMR search tokens #845)
  • removes the old import_mei_data command that was used for an older OMR-search process and is superseded by the new command
  • makes some other development-related changes, including:
    • adds development dependencies (stubs, etc.) to the project dependencies
    • explicitly exports Django models to conform the linting standards

@dchiller dchiller marked this pull request as ready for review May 15, 2024 19:35
@dchiller dchiller changed the title Mei indexer Add command in index MEI files in solr May 15, 2024
@dchiller dchiller changed the title Add command in index MEI files in solr Add command for indexing MEI files in solr May 15, 2024
Copy link
Contributor

@lucasmarchd01 lucasmarchd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think some extra exception handling would ensure that the command will always run successfully.

@dchiller
Copy link
Collaborator Author

Great suggestions...I've push some changes that add exceptions at these places.

@dchiller dchiller merged commit ab70331 into DDMAL:main May 22, 2024
2 checks passed
@dchiller dchiller deleted the mei-indexer branch May 22, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants