Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore OMR search frontend #893

Merged
merged 10 commits into from
Aug 15, 2024
Merged

Restore OMR search frontend #893

merged 10 commits into from
Aug 15, 2024

Conversation

dchiller
Copy link
Collaborator

@dchiller dchiller commented Aug 7, 2024 •
edited
Loading

Closes #876.

This PR:

  • adds some additional metadata about an OMR (Notation) search to the frontend: the number of results found and the "query" in a displayable form
  • return the integer semitones field of omr search documents
  • refactors the names of some query types
  • requires spaces between terms in contour search to conform to other omr search types

The PR also updates the README with instructions for enabling OMR search on a manuscript.

@dchiller
Copy link
Collaborator Author

@lucasmarchd01 Could you take a look at this one too?

@dchiller dchiller merged commit 833d334 into DDMAL:main Aug 15, 2024
2 checks passed
@dchiller dchiller deleted the i876-omr-frontend branch August 15, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasmarchd01 lucasmarchd01 lucasmarchd01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restore OMR search front-end
2 participants
@dchiller @lucasmarchd01