Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaning up hierarchical consistency issues #15

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bmcfee
Copy link

@bmcfee bmcfee commented Oct 6, 2016

In response to issue #13.

This PR implements the following:

  • Z boundaries are now propagated to lowercase.txt ; this was done by modifying the parser script.
  • inserting lower-case boundaries wherever there's an upper-case boundary. The notebook in the Not every boundary has a lowercase annotation #13 thread identified 171 files where this occurred. For now, I'm doing this manually by downcasing the uppers.

At some later point, #14 should replace Z boundaries with a must-have non-music tag.

I'll update the title of this PR once the smoke clears and it's ready for review.

@bmcfee
Copy link
Author

bmcfee commented Oct 6, 2016

Note about downcasing uppers: I'm only preserving the letter if it doesn't conflict with one already in use. Otherwise, I find a new unused letter.

The exception to this is when it's an obvious typo/mistake, and it's clear what the lower should be.

@bmcfee
Copy link
Author

bmcfee commented Oct 6, 2016

Hitting some strange edge cases here. For example, 765/textfile2 has lowercase annotations of the form d/b.

@jblsmith What should be done with these cases?

EDIT: it's only two files: 762/textfile2 and 775/textfile2.

@bmcfee
Copy link
Author

bmcfee commented Oct 10, 2016

quoting from previous thread:

And for non-standard letters, a standard could be: "assign ambiguous cases a new letter."

I've done this for the two tracks in question (765.2, 775.2). Everything now passes the alignment test and validates properly.

@bmcfee bmcfee changed the title [WIP] cleaning up hierarchical consistency issues cleaning up hierarchical consistency issues Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant