feat: implement user sign in and sign up #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingoo33
changed the title
pingoo33
force-pushed
the
ghostApi
branch
3 times, most recently
from
a8012dd
to
7b9cee7
Compare
ttkmw
reviewed
Mar 18, 2020
| @@ -4,11 +4,12 @@ import {Ghost} from '@/types'; | |||
|
|
|||
| @Service() | |||
There was a problem hiding this comment.
이 부분엔 어떤 수정이 있는 건지.. 실수로 추가된거라면 빼주세요~!
| } | ||
|
|
||
| public async getPublicAddress(): Promise<string> { | ||
| return await window.ethereum.enable()[0].address; |
There was a problem hiding this comment.
하드코딩을 빼면 더 좋을 것 같네요.
0이 어떤 의미인가요? 1, 2는 어떤의미이죠?
There was a problem hiding this comment.
metamask의 default account를 가져오는 것입니다.
실제로 defaultAccount라는 속성이 있지만 안정성 문제를 이유로 0번째 account에 접근하는 방식을 사용합니다.
| @@ -0,0 +1,5 @@ | |||
| export interface WalletService { | |||
| hasWallet(): boolean; | |||
There was a problem hiding this comment.
hasWallet()은 결국 publicAddress를 받기 위한 사전작업 아닌가요?
hasWallet()까지 드러내진 않아도 될 것 같은데...
만약 wallet을 반드시 가져야한다면, confirmWallet하고 리턴으로 wallet을 전달해주던가, getWallet으로 wallet을 전달해주는 게 낫지 않을까 싶습니다.
There was a problem hiding this comment.
wallet이라는 속성을 manage하는 것이 아닌, wallet에 연결되어 있는가를 확인하는 함수입니다.
interface에 추가 시킨 이유는 이 interface를 implements하는 모든 wallet service가 반드시 있어야 하는 기능이라고 생각했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.