userController&test #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
plz apply lint! |
ttkmw
force-pushed
the
feature/#9
branch
2 times, most recently
from
4603381
to
606ae21
Compare
ttkmw
commented
Jun 3, 2019
| async delete(@Param('id') id: number): Promise<DeleteResult> { | ||
| return await this.service.delete(id); | ||
| } | ||
| @Put(':id/increase-level') |
There was a problem hiding this comment.
Need Comment: @junbeomlee
not sure http method and url is good.
i referenced: github-api
PUT /repos/:owner/:repo/pulls/:pull_number/update-branch
it was using verb in url
ttkmw
force-pushed
the
feature/#9
branch
2 times, most recently
from
80da247
to
7113c91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolve: #9
Description
userController & test
Checklist
Thank you for your contribution.
Before submitting this PR, please make sure: