Implements skel functions for scope refactoring #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boohyunsik
force-pushed
the
refactor/scope
branch
2 times, most recently
from
0a19770
to
2744225
Compare
zeroFruit
reviewed
Feb 28, 2019
symbol/scope.go
Outdated
| } | ||
| // Define scope errors | ||
| type DupError struct { | ||
| Identifier ast.Identifier |
There was a problem hiding this comment.
I think it is better DupError has Symbol not Identifier
symbol/scope.go
Outdated
| s = NewEnclosedScope(s) | ||
|
|
||
| if err := ScopingFunctionParameter(f.Parameters, s); err != nil { | ||
| return nil |
symbol/scope.go
Outdated
| } | ||
|
|
||
| func (s *Scope) GetOuter() *Scope { | ||
| return s.outer | ||
| func ScopingFunctionParameter(f []*ast.ParameterLiteral, s *Scope) error { |
There was a problem hiding this comment.
why f ? could have better name
symbol/scope.go
Outdated
| for _, p := range f { | ||
| switch p.Type { | ||
| case ast.IntType: | ||
| { |
symbol/scope.go
Outdated
| err = ScopingIfStatement(implStmt, scope) | ||
| } | ||
|
|
||
| if err != nil { |
There was a problem hiding this comment.
I think this if statement don't need, just return err enough
symbol/scope.go
Outdated
| func NewScope() *Scope { | ||
| return &Scope{ | ||
| store: make(map[string]Symbol), | ||
| parent: nil, |
There was a problem hiding this comment.
These are all WIP..:-)
boohyunsik
force-pushed
the
refactor/scope
branch
7 times, most recently
from
13d2a62
to
97a9e19
Compare
hihiboss
reviewed
Mar 3, 2019
| } | ||
|
|
||
| func (s *Scope) Get(name string) Object { | ||
| scope := s |
There was a problem hiding this comment.
Why use scope variable instead of s??
There was a problem hiding this comment.
If you want to clone Scope, scope := *s or func (s Scope) Get(name string) Object {} might be right
hihiboss
reviewed
Mar 3, 2019
| r.scope = NewEnclosedScope(r.scope) | ||
|
|
||
| if err := ResolveFunctionParameter(f.Parameters, r); err != nil { | ||
| return nil |
hihiboss
reviewed
Mar 3, 2019
|
|
||
| var obj Object | ||
| var t ObjectType | ||
| switch p.Type { |
There was a problem hiding this comment.
(refactor)
How about define func resolveParamObj like
func resolveParamObj(p ast.ParameterLiteral) (Object, ObjectType) {
switch p.Type {
case ast.IntType:
return &Integer{Name: p.Identifier}, IntegerObject
...
}And,
in func ResolveFunctionParameter()
for _, p := range p {
if obj, ok := r.scope.store[p.Identifier.Name]; ok {
return DupError{
object: obj,
}
}
obj, t := resolveParamObj(p)
r.scope.store[p.Identifier.Name] = obj
r.types[p] = t
r.defs[p.Identifier] = obj
}
return nil
hihiboss
reviewed
Mar 3, 2019
| return nil | ||
| } | ||
|
|
||
| func ResolveFunctionParameter(p []*ast.ParameterLiteral, r *Resolver) error { | ||
| for _, p := range p { |
There was a problem hiding this comment.
Variable name is duplicated!
Although there is not any errors, i think it should be changed for readability.
ex) for _, param := params
hihiboss
reviewed
Mar 3, 2019
|
|
||
| func ResolveStatement(stmt ast.Statement, r *Resolver) error { | ||
| var err error | ||
| switch implStmt := stmt.(type) { |
There was a problem hiding this comment.
case *ast.AssignStatement:
return ResolveAssignStatement(implStmt, r)is better!
boohyunsik
force-pushed
the
refactor/scope
branch
from
97a9e19
to
8639abd
Compare
boohyunsik
force-pushed
the
refactor/scope
branch
from
8639abd
to
69a9ce2
Compare
boohyunsik
force-pushed
the
refactor/scope
branch
from
caac93f
to
8ec4c1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] Refactoring scope