feat: leveldb key store #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hihiboss
reviewed
Aug 16, 2020
hea9549
force-pushed
the
feat/leveldb_key_store
branch
from
fcdd386
to
2bcae79
Compare
|
이 PR과는 다소 관련이 없지만.. |
junbeomlee
reviewed
Aug 22, 2020
server/api/walletapi.go
Outdated
| @@ -43,7 +43,7 @@ func (w *WalletApi) GetWallet(context *gin.Context) { | |||
| return | |||
| } | |||
|
|
|||
| key := w.store.Get(request.ID) | |||
| key, err := w.store.Get(request.ID) | |||
There was a problem hiding this comment.
You need to handle this error.
hihiboss
reviewed
Aug 22, 2020
keychain/leveldb/store_test.go
Outdated
| func TestKeyStore_Get(t *testing.T) { | ||
| // set | ||
| dbProvider := leveldb.CreateNewDBProvider(TestTbPath) | ||
| defer func() { |
There was a problem hiding this comment.
I think you can extract this defer anonymous function :)
|
Please fix the conflict :) |
hea9549
force-pushed
the
feat/leveldb_key_store
branch
3 times, most recently
from
7bc8499
to
25c89d4
Compare
junbeomlee
approved these changes
Aug 23, 2020
hea9549
force-pushed
the
feat/leveldb_key_store
branch
from
25c89d4
to
9028148
Compare
junbeomlee
approved these changes
Aug 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.