Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some string escaping #30

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Added some string escaping #30

merged 2 commits into from
Nov 29, 2024

Conversation

RobertoRoos
Copy link
Member

@RobertoRoos RobertoRoos commented Nov 28, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.39%. Comparing base (8801ea1) to head (60c1209).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   84.39%   84.39%           
=======================================
  Files          10       10           
  Lines         737      737           
=======================================
  Hits          622      622           
  Misses        115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobertoRoos
Copy link
Member Author

@Philipp1297 only if you'd still like to, but could you test this branch on your string problem?

This fix is far from perfect, but I'm hoping this will catch 80% of practical cases.
And I just learned you could always avoid these issues by using a TwinCAT string constant instead: https://github.com/DEMCON/plcdoc/pull/30/files#diff-e890d65932fde6e97c0ea021ad58ef7aa41e838582f2755f59d0924a70323b0bR45
Of course the goal is to be compatible with all code, but I'll take baby steps.

@Philipp1297
Copy link

@RobertoRoos My project is now working without any grammer exceptions.
Thank you for your work!

@RobertoRoos RobertoRoos marked this pull request as ready for review November 29, 2024 06:59
@RobertoRoos RobertoRoos merged commit ef7df1d into master Nov 29, 2024
6 checks passed
@RobertoRoos RobertoRoos deleted the bugfix/string-escape branch November 29, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants