Generalized Thermo generation to enable Solution with arbitrary thermo#76
Merged
jiweiqi merged 1 commit intoDENG-MIT:mainfrom May 19, 2021
Merged
Generalized Thermo generation to enable Solution with arbitrary thermo#76jiweiqi merged 1 commit intoDENG-MIT:mainfrom
jiweiqi merged 1 commit intoDENG-MIT:mainfrom
Conversation
jiweiqi
approved these changes
May 19, 2021
Contributor
jiweiqi
left a comment
jiweiqi
left a comment
There was a problem hiding this comment.
This looks nice! Indeed, modularity will be very useful when more physics is included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this pull-request is related to issue #72 . It creates the IdealGasThermo in a constructor which takes the yaml as input. Futhermore, metaprogramming directly enables the use of a changed thermo model from a mechanism. (mechanism-> phase-> thermo: MyGas dispatches to
MyGasThermo(yaml).)A simillar structure could be used for kinetics and transport to make Arrhenius more modular. The thermomodel could also be constructed from the yaml file outside of CreateSolution.